Fix query parameter encoding #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -277,7 +277,7 @@ goog.Uri.prototype.resolve = function(relativeUri) { | |||
| } | |||
|
|
|||
| if (overridden) { | |||
| absoluteUri.setQueryData(relativeUri.getDecodedQuery()); | |||
| absoluteUri.setQueryData(relativeUri.getQueryData().clone()); | |||
There was a problem hiding this comment.
Nice catch! This bug appears to exist upstream, as well. Can you report and/or patch there, too? https://github.com/google/closure-library/blob/master/closure/goog/uri/uri.js#L335
There was a problem hiding this comment.
Thanks! Yes, will do.
joeyparrish
added a commit
that referenced
this pull request
Mar 27, 2015
Fix query parameter encoding
This was referenced Feb 22, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes handling of URIs with special characters. Without this patch, segment URIs such as e.g. http://example.com/0.webm?param=%26 are translated to http://example.com/0.webm?param=&.